feat: qsvdp enable join command that moarstats uses
#3252
Merged
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the join command in the qsvdp (DataPusher+ optimized) binary variant to support the moarstats command's --join-inputs functionality. The join command was previously only available in the feature_capable and lite variants, but is now needed by moarstats which is available in qsvdp.
Key changes:
- Removed feature flags restricting
joincommand and related code to onlyfeature_capableandlitebuilds - Added
joincommand toqsvdpcommand list and dispatch logic - Exposed the
SeekReadtrait andreader_file_stdinmethod needed by the join command
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/tests.rs | Removed feature gate from test_join module to enable join tests for all variants including qsvdp |
| src/maindp.rs | Added join command to command list, enum, and dispatch logic for the qsvdp variant |
| src/config.rs | Removed feature gates from SeekRead trait, implementation, and reader_file_stdin method to make them available for all variants |
| src/cmd/mod.rs | Removed feature gate from join module to expose it for all variants |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.