perf: moarstats much faster bivariate calculation
#3248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and to optimize for bivariate stats that users normally use
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a significant performance optimization to the moarstats command's bivariate statistics computation by:
- Adding a new
--bivariate-statsflag that allows users to selectively compute only the statistics they need - Changing the default behavior to compute only "fast" statistics (Pearson correlation and covariance) which use streaming algorithms
- Optimizing the Kendall tau computation to avoid unnecessary vector clones
The key changes include:
- New
BivariateStatsConfigstruct to configure which statistics to compute - Conditional allocation and computation based on the selected statistics
- Dynamic CSV header and row generation based on requested statistics
- Comprehensive test coverage for the new flag options
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/cmd/moarstats.rs | Added --bivariate-stats flag, BivariateStatsConfig struct, conditional computation logic, optimized Kendall tau, and dynamic output generation |
| tests/test_moarstats.rs | Updated existing tests to explicitly request "all" statistics where needed, and added three new tests for the flag options (pearson-only, multiple stats, and all stats) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…is triggering false positive devskim security alert being confused with a weak hashing algorithm
…csv` when `--join-inputs` is used
found by GH Copilot review, but was not flagged as it was outside the changed code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also optimized for computing streaming bivariate stats by default