feat: moarstats add bivariate stats
#3247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds bivariate statistics computation to the moarstats command, enabling analysis of relationships between pairs of columns in CSV datasets. The feature computes five correlation/covariance statistics (Pearson, Spearman, Kendall's tau, sample/population covariance) and mutual information for field pairs.
Key changes:
- Implements bivariate statistics with parallel chunked processing for large files and sequential processing for smaller datasets
- Adds multi-dataset join capability to compute bivariate statistics across joined datasets
- Includes comprehensive test coverage with 9 new test cases covering various scenarios (basic correlation, negative correlation, string fields, mixed types, joins, etc.)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/cmd/moarstats.rs | Core implementation of bivariate statistics computation including correlation algorithms, mutual information calculation, multi-dataset join support, parallel/sequential processing strategies, and extensive optimizations (date parsing cache, string interning, batch conversions) |
| tests/test_moarstats.rs | Comprehensive test suite with 9 test cases covering positive/negative correlations, string fields, multiple fields, all statistics, mixed types, joins, and index auto-creation |
| docs/STATS_DEFINITIONS.md | Documentation for bivariate statistics including definitions of Pearson/Spearman/Kendall correlations, covariance, mutual information, and multi-dataset join usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.