feat: moarstats add Atkinson Index with configurable inequality aversion parameter, Normalized Entropy & Bimodal Coefficient
#3243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormalized Entropy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds three new advanced statistics to the moarstats command: Atkinson Index with a configurable inequality aversion parameter, Normalized Entropy, and Bimodal Coefficient. These statistics provide deeper insights into data distribution characteristics, with the Atkinson Index offering a more general inequality measure than the Gini coefficient through its configurable epsilon parameter.
Key changes:
- Adds Atkinson Index computation with configurable epsilon parameter (default 1.0) via
--epsilonflag - Adds Bimodality Coefficient to detect whether distributions have single or multiple modes
- Adds Normalized Entropy as a [0,1]-scaled version of Shannon Entropy
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| src/cmd/moarstats.rs | Core implementation: adds computation functions for the three new statistics, refactors struct/function names from "KurtosisGini" to "KGA" (Kurtosis-Gini-Atkinson), adds epsilon parameter validation, and integrates new statistics into the processing pipeline |
| tests/test_moarstats.rs | Updates test suite with new test moarstats_advanced_atkinson_epsilon to verify Atkinson Index with custom epsilon value, and updates expected output to include new statistics columns |
| docs/STATS_DEFINITIONS.md | Documents the three new statistics with formulas, value ranges, and Wikipedia references |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.