feat: moarstats add "xsd_type" column
#3242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an "xsd_type" column to the moarstats command output that infers the most specific W3C XML Schema datatype based on field type and min/max values. The feature addresses issue #2858 about providing finer-grained inferred data types.
Key changes:
- Implemented
infer_xsd_type()function that maps field types to specific XSD types, with special handling for Integer types based on their min/max range - Added "xsd_type" as a new computed column in moarstats output
- Updated documentation to describe the new column and its behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/cmd/moarstats.rs | Implements the infer_xsd_type function and integrates it into the moarstats pipeline to compute XSD types for all fields; also fixes a status message to use past tense ("Ran" instead of "Running") |
| tests/test_moarstats.rs | Updates test expectations to include the new "xsd_type" column in the expected output |
| docs/STATS_DEFINITIONS.md | Adds documentation for the new "xsd_type" column explaining its purpose and how it infers types |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #2858
cc @kulnor