refactor: describegpt - consolidate JSON response parsing; cache handling; and make DuckDB & Polars error handling more consistent
#3241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- --addl-props option to handle more than one property, also remove unwrap - replace unwrap with if let when checking session state for --prompt
- consolidated JSON extraction and cache handling, removing dupe code - more consistent error handling across DuckDB and Polars SQL RAG mode
…ptions before input path
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the describegpt command to consolidate JSON response parsing, improve cache handling consistency, and make DuckDB and Polars error handling more uniform. It also adds special handling for the sample command in the run_qsv_cmd utility function.
Key changes include:
- Consolidation of duplicate JSON extraction logic into a single
extract_json_from_outputfunction - Introduction of helper functions
track_sql_error_in_session,update_session_after_sql_success, andremove_cache_entry_by_keyto eliminate code duplication - Replacement of
unwrap()calls with proper error handling in the--addl-propsvalidation - Special handling in
run_qsv_cmdto properly order arguments for thesamplecommand
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/util.rs | Added special case logic to handle sample command argument ordering in run_qsv_cmd |
| src/cmd/describegpt.rs | Consolidated JSON parsing, refactored cache handling into reusable helper functions, improved error handling consistency between DuckDB and Polars SQL execution paths, replaced unwrap() with proper error handling for --addl-props, and minor documentation alignment fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added special handling to
run_qsv_cmdto properly handlesampleas it expects options before input argument