feat: moarstats add even moar! Now with detailed outliers info!
#3208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the moarstats command by adding comprehensive outlier detection and analysis capabilities, eliminating the need for a dedicated outliers command (resolves #107). The implementation adds 12 new outlier-related statistics along with 7 additional distribution metrics, using efficient parallel processing for large datasets.
Key Changes:
- Added detailed outlier classification (extreme/mild, lower/upper) using IQR-based fence calculations
- Introduced additional statistical metrics including relative standard error, z-scores for min/max, median-to-mean ratio, IQR-to-range ratio, and MAD-to-StdDev ratio
- Implemented parallel outlier counting for indexed CSV files with automatic fallback to sequential processing
- Enhanced duplicate column prevention to avoid re-adding statistics on subsequent runs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_moarstats.rs | Adds comprehensive test coverage for outlier statistics, duplicate prevention, and edge cases including scenarios with and without outliers |
| src/cmd/moarstats.rs | Implements outlier counting with parallel processing support, adds 7 new statistical computations, and enhances documentation with detailed descriptions of all computed statistics |
…alert its ok to have the same name, as Rust has shadowing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and we no longer need a dedicated
outlierscommand. resolves #107