feat: add new "moarstats" command #3207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new moarstats command that computes additional statistical measures by extending existing stats CSV files generated by the stats command. This is Phase 1 of a larger feature, with future phases planned to support custom formulas via a DSL.
Key Changes
- Implements five new statistical measures: Pearson's Second Skewness Coefficient, Range to Standard Deviation Ratio, Quartile Coefficient of Dispersion, Bowley's Skewness Coefficient, and Z-Score of Mode
- Auto-generates baseline stats if not present, with configurable options
- Supports custom output paths and rounding precision
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| src/cmd/moarstats.rs | New command implementation with statistics computation logic and stats file handling |
| tests/test_moarstats.rs | Comprehensive test suite covering basic usage, auto-generation, custom output, rounding, value verification, and edge cases |
| src/main.rs | Registers moarstats command in full-featured build |
| src/mainlite.rs | Registers moarstats command in lite build |
| src/maindp.rs | Registers moarstats command in datapusher+ build |
| src/cmd/mod.rs | Adds moarstats module declaration |
| tests/tests.rs | Includes moarstats test module |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ing run_qsv_cmd to util Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2723
This is just Phase 1, where we compute readily available addl stats from existing stats
Future phases will include being able to use a DSL (luau, python or Mini Jinja?) to add custom formulas.