feat: describegpt sampling in prompt mode for better SQL generation…
#3198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; better DuckDB error display
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the describegpt command's SQL generation capabilities by adding configurable random sampling of the input dataset and improving DuckDB error message display.
Key Changes
- Adds a new
--sample-sizeflag (default: 100) to control the number of rows sampled from the input dataset when using prompt mode - Updates the Mini Jinja template to include the random sample data in the LLM prompt, providing additional context for SQL query generation
- Improves DuckDB error display by showing only stderr content instead of the full debug output
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/cmd/describegpt.rs |
Adds flag_sample_size parameter, integrates it into the sampling logic and template context, and improves DuckDB error message parsing to display only stderr |
resources/describegpt_defaults.toml |
Updates documentation comments for the new sample_size template variable and adds a new template section to include sample data in the SQL generation prompt |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also better DuckDB error display