feat: describegpt use minijinja engine for prompt processing
#3188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duce JSON unreliably
moving prompt building more to minijinja
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the describegpt command by migrating from a manual string replacement approach to using the minijinja template engine for prompt processing. This aligns describegpt with other qsv commands (template and fetchpost) that already leverage minijinja for dynamic content generation. Additionally, the PR includes improvements to JSON extraction logic to better handle common formatting issues from LLM responses.
Key Changes
- Replaced manual string replacement (
.replace("{VARIABLE}", value)) with minijinja template engine rendering - Updated template syntax in
resources/describegpt_defaults.tomlfrom{VARIABLE}to{{ variable }}(Jinja2 syntax) - Enhanced JSON extraction with automatic fixing of common issues (unescaped newlines, tabs, carriage returns in strings)
- Added fallback patterns for extracting JSON from LLM responses with both non-greedy and greedy regex matching
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/cmd/describegpt.rs | Integrated minijinja for template rendering, replaced manual string substitution with context-based rendering, improved JSON extraction with auto-fixing logic for malformed responses, and updated documentation |
| resources/describegpt_defaults.toml | Migrated all prompt templates from {VARIABLE} to {{ variable }} Jinja2 syntax, added conditional logic with {% if %} blocks, used {% raw %} blocks to escape JSON examples, and updated variable documentation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3023