feat: describegpt add --language option
#3184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a --language option to the describegpt command, allowing users to specify the output language for LLM-generated descriptions. When set, the language instruction is prepended to the prompt and injected into tag generation prompts to influence the model's response language. The change includes documentation, argument parsing, prompt generation modifications, and cache key updates to properly invalidate cached results when language settings change.
Key Changes
- Added
--language <lang>flag to specify the output language for LLM responses - Modified prompt generation to include language instructions when the flag is provided
- Updated cache key generation to include the language parameter for proper cache invalidation
…nd configurable.
also, remove leading space from {LANGUAGE} instances as leading space is inserted back when --language is set, and blank otherwise.
This makes the prompt read normally and not have weird double-spacing when language is not set per GH Copilot review.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- remove curly braces escaping as we are using to_string, not format! macro - document it - language prompt variables are processed the same way as others. - no need for mutable prompt
…Characteristics section in Description is in the requested language.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.