feat: describegpt add --add-cols and --addl-cols-list <list> options
#3179
+267
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed for addl-cols serialization
tweak implementation comments
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to include additional columns from Summary Statistics in the Data Dictionary generated by the describegpt command. This enhances the dictionary with statistical measures like mean, median, MAD, standard deviation, variance, and coefficient of variation.
Key Changes:
- Introduces
--addl-colsflag to enable additional columns and--addl-cols-listoption to specify which columns to include (with a sensible default list of statistical measures) - Updates the default stats options to include
--mad --quartiles --percentilesfor richer statistical context - Modifies data structures (
DictionaryEntry,StatsRecord) to useIndexMapfor preserving column order - Enhances output formatting functions (markdown, JSON, TSV) to dynamically include additional columns
- Adds command line information to attribution metadata
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/cmd/describegpt.rs | Core implementation adding --addl-cols and --addl-cols-list options with support for dynamic additional columns in dictionary output across all formats (markdown, JSON, TSV). Includes new helper function determine_addl_cols() and updates to parsing/formatting logic. |
| Cargo.toml | Enables the "serde" feature for the indexmap dependency to support serialization of the new IndexMap fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to add more columns to the Data Dictionary from the Summary Statistics