feat: lens add --streaming-stdin option
#3171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a --streaming-stdin option to the lens command to enable streaming of stdin data instead of loading the entire input into a temporary file before displaying. This aligns with the project's performance goals by avoiding unnecessary buffering for stdin input when the user wants immediate visualization.
Key changes:
- Added
--streaming-stdinflag that bypasses theutil::process_inputbuffering for stdin - Updated csvlens dependency to version
b407076which includes support for streaming stdin - Added validation to ensure
--streaming-stdinis only used with stdin input (not with file arguments)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/cmd/lens.rs | Added --streaming-stdin flag, input validation, conditional processing logic to bypass buffering when streaming is enabled, and field alignment improvements in Args struct |
| Cargo.toml | Updated csvlens dependency from rev 67d92b7 to b407076 to support the new streaming feature |
| Cargo.lock | Reflects csvlens dependency update and addition of csv-core as a transitive dependency |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.