feat: describegpt add lookup support
#3170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reorged usage text into logical sections - tag-vocab now just supports regular CSV format; removed kv pair separated by a colon text file format - qsvlite only support local files for tag-vocab; feature-capable build can use CKAN, disk-cache, dathere scheme
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds lookup support to the describegpt command, enabling the --tag-vocab option to load tag vocabulary from multiple sources including local files, remote URLs (HTTP/HTTPS), CKAN resources (ckan://), and dathere:// scheme resources. This extends the tag inference capability by allowing users to constrain tags to a predefined vocabulary that can be centrally managed and accessed remotely.
Key changes:
- Integration of the existing
lookupmodule to handle remote resource fetching and caching for tag vocabularies - Addition of new CLI options (
--cache-dir,--ckan-api,--ckan-token) to configure remote resource access - Comprehensive test coverage for both valid and error cases (invalid CSV format, missing files)
- Updated documentation with detailed examples for all supported tag vocabulary sources
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/cmd/describegpt.rs | Added lookup module integration for tag vocabulary loading, new CLI arguments for cache/CKAN configuration, CSV parsing logic for tag vocab files, and initialization logic for tag vocabulary cache settings. Also reorganized help text sections and moved --format option under Common options. |
| tests/test_describegpt.rs | Added three new test cases: valid tag vocabulary CSV usage, invalid CSV with missing column, and non-existent file error handling. |
| docs/Describegpt.md | Added comprehensive documentation for Tag Options including --tag-vocab, --cache-dir, --ckan-api, --ckan-token with examples demonstrating local files, remote URLs, and CKAN resource usage. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3123