feat: describegpt replace --json option with --format option supporting 3 formats - markdown, json and TSV; remove --jsonl option
#3167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove DuckDB MCP validation for now as its not reliable - write each output kind to its own TSV - rust fmt
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the --json and --jsonl command-line options with a unified --format option that supports three output formats: markdown (default), json, and tsv. The change also removes DuckDB MCP validation support and the associated sample file generation code. The new TSV format provides an easier-to-parse alternative to CSV for data with free text containing commas.
Key changes:
- Introduced
OutputFormatenum with Markdown, Tsv, and Json variants - Replaced
--json/--jsonlflags with--formatoption accepting "markdown", "md", "tsv", or "json" - Added five new TSV formatting functions for different prompt types
- Removed DuckDB MCP extension support and sample file generation logic
- Updated validation to require
--outputflag when using TSV format
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/cmd/describegpt.rs | Implements the new --format option, adds OutputFormat enum and TSV formatting functions, removes DuckDB MCP support and sample file generation, updates output format detection and file path handling for TSV |
| resources/describegpt_defaults.toml | Updates version to 6.2.0, removes jsonl field, refines DuckDB SQL guidance to reference Data Dictionary |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3155
we use TSV instead of CSV as its easier to parse, especially for input data with free text using commas.