fix: partition add proper stdin handling regression introduced when --limit option was added
#3161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix stdin bug introduced while adding `--limit` option #2959
…reads with --limit option
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in the partition command's stdin handling that was introduced when the --limit option was added. The --limit feature processes data in batches to avoid exceeding OS file handle limits, requiring multiple passes over the input data. Since stdin can only be read once, this caused failures when using stdin with partitioning. The fix writes stdin to a temporary file before processing, allowing the batch logic to work correctly.
Key Changes:
- Modified
partitioncommand to detect stdin input and write it to a temporary file - Added comprehensive test to verify stdin handling with the
--limitflag - Implemented cleanup logic for the temporary file after processing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/cmd/partition.rs | Added stdin detection and tempfile handling logic (lines 105-122) and cleanup logic (lines 132-136) to enable stdin input with batch processing |
| tests/test_partition.rs | Added partition_stdin_pipeline test to verify stdin input works correctly with --limit flag, testing multiple unique partition values across batches |
Contributor
|
@jqnatividad I've opened a new pull request, #3162, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: jqnatividad <1980690+jqnatividad@users.noreply.github.com>
Align partition stdin handling with split/stats pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3160
This stdin handling bug was inadvertently introduced when the
--limitoption was added to allow partitioning using columns with very high cardinality which opened thousands of file handles that overran the OS limit.This was "fixed" by partitioning in batches below the operating system limit. This however, required, reading the input file several times which doesn't work with stdin as its consumed once its read for the first time, causing the stdin regression.
Fixed by writing stdin to a tempfile.