feat: stats add n_negative, n_zero, n_positive count columns
#3157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds three new statistical columns (n_negative, n_zero, n_positive) to the stats command output, providing counts of negative, zero, and positive numeric values for Integer and Float data types.
Key Changes
- Extended the
StatsDatastructure with three new optional u64 fields for the count columns - Updated
MAX_STAT_COLUMNSconstant from 44 to 47 to accommodate the new columns - Added column definitions to
STATSDATA_TYPES_MAPas JsonTypes::Int - Inserted the new columns in the output header and data records between
nullcountandmax_precision - Updated all test files and expected output resources to include the new columns with appropriate values
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/cmd/stats.rs | Core implementation: added fields to StatsData struct, updated constants, and added output logic for the three new count columns |
| tests/test_stats.rs | Updated all test expectations to include the new columns with correct values for various test scenarios |
| resources/test/*.csv | Updated all expected output CSV files with the new columns and recalculated fingerprint hashes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2858 (comment)