chore: remove jemalloc support #3153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes jemalloc allocator support from qsv in response to the jemalloc project's postmortem announcement. The change simplifies the codebase by reducing the number of supported memory allocators from three (mimalloc, jemalloc, standard) to two (mimalloc (default), standard).
Key Changes:
- Removed tikv-jemallocator dependency and all jemalloc-related conditional compilation directives
- Updated documentation across multiple files to reflect that only mimalloc and standard allocators are now supported
- Simplified environment variable checking logic to remove JEMALLOC_ and MALLOC_CONF prefix checks
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.rs | Removed jemalloc global allocator declaration |
| src/maindp.rs | Removed jemalloc global allocator declaration |
| src/mainlite.rs | Removed jemalloc global allocator declaration |
| src/util.rs | Simplified malloc_kind version string logic and environment variable checking by removing jemalloc branches |
| Cargo.toml | Removed tikv-jemallocator dependency |
| Cargo.lock | Removed tikv-jemallocator and tikv-jemalloc-sys package entries |
| docs/PERFORMANCE.md | Updated documentation to remove jemalloc references and installation instructions |
| docs/FEATURES.md | Removed jemallocator feature from feature list |
| docs/ENVIRONMENT_VARIABLES.md | Updated to remove jemalloc environment variable documentation |
| docs/contributor/PROJECT_TECHNICAL_OVERVIEW.md | Updated allocator count from "optional" to "two" |
| README.md | Updated memory allocator description and test example |
| CLAUDE.md | Updated memory management section to remove jemalloc |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://jasone.github.io/2025/06/12/jemalloc-postmortem/