feat: validate add email validation options
#3148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds configurable email validation options to the validate command, allowing users to customize email format validation behavior when using JSON Schema validation with the "email" format keyword. The changes leverage unreleased features from the upstream jsonschema library.
- Adds four new command-line flags to control email validation behavior:
--email-required-tld,--email-display-text,--email-min-subdomains, and--email-domain-literal - Updates the jsonschema dependency to use an unreleased git revision with email validation features
- Adds comprehensive test coverage for the new email validation options
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| Cargo.toml | Adds a patch to use upstream jsonschema with unreleased email validation features |
| Cargo.lock | Updates jsonschema and referencing dependencies to use the git revision |
| src/cmd/validate.rs | Implements email validation options in the validate command, including help text, flag declarations, and option builder logic |
| tests/test_validate.rs | Adds comprehensive tests for email validation including default behavior and various option combinations |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…bdomains default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.