feat: describegpt improved Polars SQL processing
#3147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
already pulled in by minijinja-contrib, so we're not making the dependency tree bigger we need this to wrap long prompts
…arseable/human-readable for `describegpt`
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the describegpt command's Polars SQL processing capabilities by improving error reporting and attribution formatting. The changes focus on providing clearer error messages when SQL queries fail and better formatting of prompt information in generated SQL output.
- Improved SQL error message formatting with clear query and error separation
- Enhanced attribution metadata to include wrapped user prompts as properly formatted SQL comments
- Updated Polars SQL guidance with more accurate function references and reorganized LLM instructions
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/cmd/sqlp.rs | Enhanced error message formatting to display failed queries with clear separation between query text and error details |
| src/cmd/describegpt.rs | Added textwrap support for formatting user prompts as SQL comments in attribution metadata, improved error message passing from sqlp stderr |
| resources/describegpt_defaults.toml | Updated Polars SQL function reference URL, refined date operation guidance, reorganized LLM instruction ordering for better prompt flow |
| Cargo.toml | Added textwrap dependency for text wrapping functionality |
| Cargo.lock | Updated lock file with textwrap dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.