refactor: parallel chunk sizing - allow forcing of cpu based chunking #3138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors parallel chunk sizing logic in the stats and frequency commands to allow forcing CPU-based chunking via the environment variables QSV_STATS_CHUNK_MEMORY_MB and QSV_FREQ_CHUNK_MEMORY_MB. The refactoring introduces support for setting these variables to -1 to force CPU-based chunking (chunk size = records/number of CPUs) as an alternative to memory-aware chunking.
Key changes:
- Modified environment variable parsing to support
-1value for forcing CPU-based chunking - Refactored chunking logic to consolidate mode determination and logging
- Updated documentation across command help text, dotenv template, and environment variable docs
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/cmd/stats.rs | Refactored chunk size calculation logic to support CPU-based chunking when env var is unset or set to invalid value; improved code structure and logging |
| src/cmd/frequency.rs | Applied similar chunking refactor as stats.rs; removed commented-out code |
| dotenv.template | Added documentation for -1 value to force CPU-based chunking for both STATS and FREQ env vars |
| docs/ENVIRONMENT_VARIABLES.md | Updated descriptions for QSV_STATS_CHUNK_MEMORY_MB and QSV_FREQ_CHUNK_MEMORY_MB to document -1 option |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.