feat: sample add timeseries sampling options
#3130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clippy::match-wildcard-for-single-variants
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds timeseries sampling functionality to the sample command, allowing users to sample time-series data by grouping records into time intervals and selecting/aggregating records within those intervals. This is particularly useful for downsampling large time-series datasets while preserving temporal patterns.
Key Changes:
- Added
--timeseriesflag and related options (--ts-interval,--ts-start,--ts-adaptive,--ts-aggregate,--ts-input-tz,--ts-prefer-dmy) - Implemented interval-based sampling with support for hourly, daily, weekly, monthly, and yearly intervals
- Added adaptive sampling modes to prefer records from specific time periods (business hours, weekends, business days)
- Included aggregation functions (mean, sum, min, max, median, first, last, count) for combining multiple records within intervals
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| src/cmd/sample.rs | Core implementation of timeseries sampling including new enum types (TSStartMode, AggregationFunction, AdaptiveMode), parsing functions for timestamps and intervals, and the main sampling logic with grouping, selection, and aggregation capabilities |
| tests/test_sample.rs | Test suite covering basic timeseries sampling scenarios including daily/hourly intervals, different start modes (first/last), aggregation (mean), and error cases (invalid column, invalid interval) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2589