feat: schema infer addl JSONschema predefined formats - email, ipv4, ipv6, hostname
#3125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to infer JSONschema predefined formats - email, ipv4, ipv6 and hostname
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for inferring and enforcing JSON Schema format constraints for email, hostname, IPv4, and IPv6 address columns in the schema command. When the new --strict-formats flag is enabled, the schema command automatically detects these common data formats and adds appropriate format constraints to the generated JSON Schema.
Key changes:
- Added format detection for email, hostname, IPv4, and IPv6 addresses with proper precedence (most specific first)
- Format constraints are only applied when ALL unique values in a column match the detected format
- Comprehensive test coverage with 6 new tests covering happy paths, mixed values, and precedence rules
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/cmd/schema.rs | Core implementation: adds --strict-formats flag, implements format detection functions (is_email, is_hostname, is_ipv4, is_ipv6), and infer_format_from_values logic with correct precedence ordering |
| src/util.rs | Adds flag_strict_formats field to SchemaArgs struct and initializes it in infer_polars_schema |
| src/cmd/tojsonl.rs | Initializes flag_strict_formats to false in SchemaArgs construction |
| src/cmd/sample.rs | Initializes flag_strict_formats to false in SchemaArgs construction |
| src/cmd/pivotp.rs | Initializes flag_strict_formats to false in SchemaArgs construction (two occurrences) |
| src/cmd/joinp.rs | Initializes flag_strict_formats to false in SchemaArgs construction |
| src/cmd/frequency.rs | Initializes flag_strict_formats to false in SchemaArgs construction |
| src/cmd/diff.rs | Initializes flag_strict_formats to false in SchemaArgs construction |
| tests/test_schema.rs | Adds 6 comprehensive tests covering email, hostname, IPv4, IPv6 formats, mixed values behavior, and IPv4/hostname precedence |
| Cargo.toml | Adds hostname-validator 1.1 dependency for hostname validation |
| Cargo.lock | Updates lock file with hostname-validator 1.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3101