feat: frequency add --rank-strategy
#3075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename `--rank-ties-strategy` to `--rank-strategy` with `-r` shortcut - optimize rank evaluation so its not inside a hot loop - remove Default impl as we set the default in docopt
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive ranking strategies for frequency tables, expanding beyond the previous single "min" strategy to include all standard ranking methods (min, max, dense, ordinal, and average) as defined in the Wikipedia ranking article. The implementation follows R's naming conventions for these strategies.
Key Changes:
- Added
--rank-strategyflag with five options: min, max, dense, ordinal, and average - Changed rank data type from
u32tof64to support fractional ranks (average strategy) - Updated rank formatting logic to display integers when possible, decimals when needed
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/cmd/frequency.rs |
Core implementation of RankStrategy enum, ranking algorithms for each strategy, and rank formatting logic |
src/cmd/schema.rs |
Added default RankStrategy::Min to schema command integration |
tests/test_frequency.rs |
Comprehensive test suite covering all ranking strategies, edge cases, and JSON output validation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing all the strategies listed here
https://en.wikipedia.org/wiki/Ranking
Before, we were only doing Standard Competition Ranking/("min" ranking in R).
Use R naming convention for the different strategies.