feat: add blake3 file hashing helper #3072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
much much faster than single threaded sha256
including latest qsv-tuned csv fork with more inlines
to be initially used with `describegpt`, and possibly for stats_cache
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new BLAKE3 file hashing helper function to leverage BLAKE3's parallelizable hashing capabilities, providing significantly faster performance compared to SHA256 for file hashing operations. The implementation uses memory mapping and Rayon-based parallel processing for optimal performance.
Key Changes
- Added
hash_blake3_file()function that uses BLAKE3's optimized memory-mapped and parallel hashing - Added
blake3dependency withrayonandmmapfeatures enabled - Included comprehensive test coverage with correctness tests and benchmark tests for various file sizes
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/util.rs | Added hash_blake3_file() function with extensive tests for correctness and performance benchmarking |
| Cargo.toml | Added blake3 dependency with rayon and mmap features |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blake3 is a valid
spdx::algorithmthat's parallelizable unlike sha256 - which is inherently single-threaded by design.This makes it much, much faster than sha256.
https://crates.io/crates/blake3
see DOI-DO/dcat-us#225