refactor: Replace localzone with iana time zone #3048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that's already used by chrono
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the timezone detection functionality by replacing the localzone crate with the iana-time-zone crate for getting the local timezone. This change affects the datefmt command's timezone handling logic.
- Replaced
localzone::get_local_zone()calls withiana_time_zone::get_timezone() - Updated error handling pattern from
OptiontoResult - Removed dependency on
localzonecrate and addediana-time-zonecrate
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/cmd/datefmt.rs | Updated three timezone detection calls to use the new iana-time-zone library with Result-based error handling |
| Cargo.toml | Removed localzone dependency and added iana-time-zone dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.