refactor: add big-endian handling #3045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for platforms like s390x
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds big-endian platform support by conditionally using serde_json instead of simd_json on big-endian architectures like s390x, addressing endianness compatibility issues.
- Adds conditional compilation attributes to use serde_json on big-endian platforms
- Replaces simd_json usage with serde_json for JSON parsing and serialization on big-endian systems
- Refactors existing JSON handling code to support both endianness types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/util.rs | Adds conditional JSON parsing/serialization for big-endian platforms in stats record processing and CSV to JSONL conversion |
| src/cmd/stats.rs | Updates stats argument deserialization and JSON output generation with endian-specific handling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for platforms like s390x