fix: extdedup really use memmapped ondisk hash table
#3020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the extdedup command to properly use memory-mapped on-disk hash tables instead of in-memory hash tables when memory limits are exceeded. The fix addresses issue #2462 by ensuring that the hash table operations work directly with the memory-mapped file rather than creating separate in-memory copies.
Key changes:
- Refactored ExtDedupCache to work directly with memory-mapped hash tables instead of maintaining separate disk and memory structures
- Added comprehensive test coverage for large dataset deduplication with memory constraints
- Simplified the hash table initialization process to use proper memory-mapping
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/odhtcache.rs | Refactored to use HashTable directly with memory mapping instead of HashTableOwned, removed duplicate disk field, and simplified initialization |
| tests/test_extdedup.rs | Added comprehensive test for large dataset deduplication with memory limits and helper function to generate test data |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2462