deps: replace tabwriter with renamed fork qsv-tabwriter #3010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we had several required changes that will not be merged to tabwriter, so we ended up creating a renamed fork also bumped qsv-sniffer to switch it to qsv-tabwriter
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the tabwriter dependency with a renamed fork qsv-tabwriter to incorporate custom changes that won't be merged upstream. This simplifies maintenance by avoiding patch sections in Cargo.toml.
Key changes:
- Replace all
tabwriterimports withqsv_tabwriteracross multiple command modules - Add
qsv-tabwriter = "2"dependency and remove the oldtabwriterdependency - Remove the git patch configuration for the old tabwriter fork
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updates dependencies by adding qsv-tabwriter and removing tabwriter along with its git patch |
| src/cmd/to.rs | Updates TabWriter instantiation to use qsv_tabwriter |
| src/cmd/table.rs | Updates import statement to use qsv_tabwriter for TabWriter and Alignment |
| src/cmd/sniff.rs | Updates import statement to use qsv_tabwriter for TabWriter |
| src/cmd/headers.rs | Updates import statement to use qsv_tabwriter for TabWriter |
| src/cmd/flatten.rs | Updates import statement to use qsv_tabwriter for TabWriter |
fixes MSRV issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as we made changes that will not be merged into tabwriter, so we ended up creating a renamed fork.
Doing this instead of using patch section of Cargo.toml for easier maintenance