fix:schema delimiter detection
#2998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…detecting delimiter properly
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes delimiter detection for the schema command, specifically addressing issue #2997 where TSV files were incorrectly parsed with comma delimiters instead of tabs, causing column concatenation issues.
- Updated the schema command to properly auto-detect delimiters based on file extensions
- Modified the
get_stats_recordsfunction to use qsv's Config system for delimiter detection - Added comprehensive test coverage for TSV delimiter detection
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/cmd/schema.rs | Updated help text to remove hardcoded comma default delimiter |
| src/util.rs | Enhanced get_stats_records function with proper delimiter detection logic using qsv's Config system |
| tests/test_schema.rs | Added comprehensive test for TSV delimiter detection to prevent regression |
| tests/test_pivotp.rs | Updated test expectations to match new float formatting and added aggregation parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2997