fix: describegpt --base-url option being ignored
#2977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the --base-url option in the describegpt command was being ignored when no QSV_LLM_BASE_URL environment variable was set. The fix ensures that command-line flags take precedence over default configurations when environment variables are not present.
- Modified the base URL selection logic to check for the
--base-urlflag when the environment variable is not set - Added a unit test to verify the fix works correctly by ensuring the custom base URL is used instead of the default OpenAI URL
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/cmd/describegpt.rs | Added fallback logic to use --base-url flag when QSV_LLM_BASE_URL environment variable is not set |
| tests/test_describegpt.rs | Added unit test to verify the --base-url flag is properly respected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2976
Mea culpa as most
describegpttesting was done with QSV_LLM_BASE_URL env var set