feat: partition add --limit option
#2960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a --limit option to the partition command to control the number of simultaneously open files, addressing the "too many open files" error when partitioning large datasets with many unique values. The implementation processes data in batches when a limit is specified, automatically defaults to 90% of the system limit for safety, and allows unlimited processing when set to 0.
Key changes:
- Added
--limitparameter with automatic system limit detection and validation - Refactored partition logic to support batched processing with file limit constraints
- Added comprehensive test coverage for the new batching functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/cmd/partition.rs | Implements the core batching logic, system limit detection, and refactors existing partition methods to support file limits |
| tests/test_partition.rs | Adds test case verifying that partition works correctly with file limits while maintaining data integrity |
also applied clippy lint below
warning: deref on an immutable reference
--> src/cmd/partition.rs:296:38
|
296 | wtr.write_record(&*headers)?;
| ^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `headers`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `#[warn(clippy::borrow_deref_ref)]` on by default
…word and the r# prefix is just confusing [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2959
cc @harto