refactor: describegpt Polars SQL generation tweaks
#2958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable `--stats-jsonl` by default when generating stats - correct INPUT_TABLE_NAME sentinel const - moved overly verbose LLM API JSON get/response debug to trace - removed excess newline before starting REASONING section - just propagate file operations instead of overly verbose error msg - when running Polars SQL with sqlp command, set `--infeer-len` to 10000 - better error handling when Polars SQL fails
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the describegpt command's Polars SQL generation functionality by improving defaults, error handling, and debugging output. The changes focus on making the tool more robust and user-friendly when working with SQL query generation and execution.
- Enable
--stats-jsonlby default for better structured stats output - Improve error handling and messaging for Polars SQL execution failures
- Optimize debug logging and SQL execution parameters
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/cmd/describegpt.rs | Updates default stats options, fixes constant naming, improves error handling for SQL execution, and optimizes debug logging |
| resources/describegpt_defaults.toml | Adds SQL function restrictions and date operation guidance for Polars SQL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--stats-jsonlby default when generating stats--infeer-lento 10000