feat: describegpt add configurable frequency limit
#2950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, it was hardcoded to top 10, now its configurable and defaults to top 50
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configurable enum threshold parameter to the describegpt command, allowing users to control how many top frequent values are included in frequency distributions before other values are grouped into an "Other" category.
- Adds
--enum-thresholdflag with default value of 50 (previously hardcoded to 10) - Updates system prompt template to use dynamic
{TOP_N}placeholder replacement - Modifies cache key generation to include the enum threshold for proper cache invalidation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/cmd/describegpt.rs | Adds enum-threshold parameter, updates frequency command calls, and modifies cache key generation |
| resources/describegpt_defaults.json | Updates system prompt template to use dynamic TOP_N placeholder instead of hardcoded "10" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, it was hardcoded to top 10, now its configurable and defaults to top 50.
The default system prompt now has a
{TOP_N}sentinel value that is replaced with the specified --enum-threshold