Skip uploading Python 3.4 coverage on Appveyor #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d1e863 to
1e365fd
Compare
1e365fd to
92e749b
Compare
Coverage 5.x has made some backwards-incompatible changes to its format and cannot understand the format generated by coverage 4.x. Since coverage 5.x does not support Python 3.4 and the "combine and upload" job is using Python 3.6 (and thus `coverage >= 5`), coverage uploading was broken. It is possible to get this working again, but probably more trouble than it is worth, since as far as I can tell there are no lines hit *only* by the Python 3.4 tests on Windows, so we can leave it out of the combined coverage measurement.
92e749b to
2047c1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Builds have started failing on appveyor because we're using coverage 4.x to generate coverage data, but coverage 5.x to process it on Windows. This is because we're always using Python 3.6 to invoke
tox, so thecoveragejob picks up a more recent version ofcoveragethan thepy34job.As far as I can tell there are no lines uniquely hit by the Python 3.4-on-Windows tests, so we're not losing any coverage by not including it in the coverage uploads. I say it's not really worth trying to fix this, so I've just skipped the upload step on Python 3.4.
Pull Request Checklist