migrate away from unittest and adopt pytest for test_imports #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
reviewed
Nov 18, 2019
f037744 to
2a1398c
Compare
2a1398c to
4d62994
Compare
3 tasks
Member
|
@jpurviance Can you rebase and add a news fragment for this? Also there may be conflicts with #1007, though I think they will be minor if this gets merged first. I'll also note that I think we can save it for a separate PR, but the "clean imports" fixture I suggested in #1007 would be useful for I think all of these functions. I wonder if it would make sense to leave these tests on one or more classes (just remove the |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes
Pull Request Checklist