Fix test_tzlocal_offset_equal[GMT-tzoff1] #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
approved these changes
Nov 3, 2019
test_tzlocal_offset_equal[GMT-tzoff1] fails if a system does not have a defined (installed) GMT timezone, for example if "Link Etc/GMT GMT" is not defined in the zoneinfo configuration: > assert tz.tzlocal() == tzoff E AssertionError: assert tzlocal() == tzoffset(u'GMT', 0) E -tzlocal() E +tzoffset(u'GMT', 0) An example of such a configuration is FreeBSD, who's default timezone is UTC [1][2]. This configuration results in any "non-present" or undefined TZ name being returned/processed as the default timezone name (in FreeBSD's case, UTC). Further, POSIX does not recognize [3] TZ=GMT or TZ=UTC as valid values because they neither start with a colon nor contain a numeric offset hour field. Accordingly, update the GMT value for this parametrized test to GMT0, a specific (not aliased) timezone, making it more robust to system configuration differences. [1] https://svnweb.freebsd.org/changeset/base/130332 [2] https://svnweb.freebsd.org/changeset/base/199405 [3] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html
Merged
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_tzlocal_offset_equal[GMT-tzoff1] fails if a system does not
have a defined (installed) GMT timezone, for example if "Link Etc/GMT GMT"
is not defined in the zoneinfo configuration:
E AssertionError: assert tzlocal() == tzoffset(u'GMT', 0)
E -tzlocal()
E +tzoffset(u'GMT', 0)
An example of such a configuration is FreeBSD, who's default timezone is
UTC [1][2]. This configuration results in any "non-present" or undefined TZ
name being returned/processed as the default timezone name (in FreeBSD's
case, UTC).
Further, POSIX does not recognize [3] TZ=GMT or TZ=UTC as valid values
because they neither start with a colon nor contain a numeric offset hour
field.
Accordingly, update the GMT value for this parametrized test to GMT0, a
specific (not aliased) timezone, making it more robust to system
configuration differences.
[1] https://svnweb.freebsd.org/changeset/base/130332
[2] https://svnweb.freebsd.org/changeset/base/199405
[3] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html
Summary of changes
Closes #918
Pull Request Checklist