More caching and singletons in tz #628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the upcoming 2.7.0 release, I think it's important for at least
tz.gettzto return the same zone for the same inputs unless otherwise specified.This PR makes
tzstra singleton, adds caching totz.gettzand adds the.instancealternate constructor fortzoffsetandtzstr.I did not bother with a
.instancealternate constructor fortzutc, because the semantics oftzutcare not affected by inter- and intra-zone comparisons (technically true oftzoffsetas well, too).