Skip to content

Conversation

@pganssle
Copy link
Member

@pganssle pganssle commented Nov 5, 2017

This changes the test runner over to pytest.

@pganssle pganssle added the tests label Nov 5, 2017
@pganssle pganssle added this to the 2.7.0 milestone Nov 5, 2017
@pganssle
Copy link
Member Author

pganssle commented Nov 5, 2017

@jbrockmendel @mariocj89 I think this is fine, any comments? I'd like to merge ASAP so that everyone else can start using pytest.

@mariocj89
Copy link
Member

Looks great! I'd personally add a -vvvv for pytest to get the history of test run on the builds

@pganssle
Copy link
Member Author

pganssle commented Nov 5, 2017

@mariocj89 Ah, good call, I didn't notice that that was missing.

@pganssle
Copy link
Member Author

pganssle commented Nov 5, 2017

What is the difference between -v and -vvvv?

@mariocj89
Copy link
Member

Just realized, it actually changes the way some diffs are reported.

-v will add the test name in the reports. having multiple v just increases the level of verbosity, which adds extra information on some assertion failures.

Example, if you assert two diffs which are different but big, adding extra verbosity will print the whole dict whilst just -v won't.
You are probably fine with just -v here

@pganssle
Copy link
Member Author

pganssle commented Nov 5, 2017

OK, we can change it later if -vvv is better.

@pganssle pganssle merged commit 11f47be into dateutil:master Nov 5, 2017

script:
- coverage run --omit=setup.py,dateutil/test/* setup.py test
- coverage run --omit=setup.py,dateutil/test/* -m pytest -v
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a pytest-cov plugin, not sure to what extent there is a "preferred" usage of that vs this usage.

@jbrockmendel
Copy link
Contributor

Little late, but LGTM.

@pganssle pganssle mentioned this pull request Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants