Make zoneinfo tzfile superclass less confusing #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, this was confusing to mypy. The new code is slightly easier to understand if you don't know what's going on, IMO, otherwise I wouldn't necessarily change valid upstream code to appease a typechecker. Specifically, before this change: $ mypy dateutil/zoneinfo/__init__.py | grep zoneinfo dateutil/zoneinfo/__init__.py:18: error: Name 'tzfile' already defined (possibly by an import) dateutil/zoneinfo/__init__.py:18: error: Cycle in inheritance hierarchy That Cycle inheritance one is bad enough to cause mypy to give an error even with `--follow-imports=silent`, which might be a bug in mypy.
Member
|
This is very reasonable. I will merge when the tests pass. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, this was confusing to mypy.
The new code is slightly easier to understand if you don't know what's going
on, IMO, otherwise I wouldn't necessarily change valid upstream code to appease
a typechecker.
Specifically, before this change:
That Cycle inheritance one is bad enough to cause mypy to give an error even
with
--follow-imports=silent, which might be a bug in mypy, but, like I said,I think the new code is more obvious to humans.