Skip to content

add check for valid hour, with test #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pganssle merged 1 commit into from
Oct 27, 2017
Merged

add check for valid hour, with test #482

pganssle merged 1 commit into from
Oct 27, 2017

Conversation

@jbrockmendel
Copy link
Contributor

@jbrockmendel jbrockmendel commented Oct 27, 2017

Closes #353

There is one more place where the same valid-hour check should be done, but I'm leaving that until I have a test case ready.

pganssle
pganssle approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

@pganssle pganssle merged commit e84439c into dateutil:master Oct 27, 2017
@pganssle pganssle added this to the 2.7.0 milestone Oct 27, 2017
@pganssle pganssle mentioned this pull request Mar 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle pganssle approved these changes

Assignees

No one assigned

Labels

bug parser

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @pganssle