Added 'RRULE:' in rrule.__str__ to be RFC compliant #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dateutil#86 ; courtesy to @jarondl for the initial patch
Member
|
OK, I think this is fine. |
Member
|
@mlorant Sorry, I should be more enthusiastic - thank you for your contribution to dateutil! This issue has been open for a while and had fallen off my radar a bit, but it's good to get us up to standards-compliance here. I'm going to go ahead and merge this for the next feature release (2.7.0), we'll see if anyone downstream picking up our changes was relying on the old behavior. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86 ; courtesy to @jarondl for the initial patch