Fix some Python 3 issues flagged by the -3 flag #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been working through looking at adopting Python 3, and I've been utilizing the -3 flag to help idenitfy issues with Python 3. Here's a quick write up I did last week: https://gist.github.com/rowillia/c0feed97c1863b2d8e5a3ed73712df65 The -3 flagged a few issues in dateutil worth fixing, namely around __eq__ shadowing __hash__ in PY3. Fixing these issues will help make the -3 flag less noisey for folks running dateutil in production.
Contributor
Author
|
@pganssle Let me know if you've got any questions on this! |
Member
|
@rowillia Yes, sorry for the delay, it's been some time since I've had time to work on I guess the issue is that classes default to hashable in Python 2, but to non-hashable in Python 3? I suppose if it hasn't come up already in Python 3 compatibility already, it's not a behavior too many people are relying on. I would normally say we should add some tests, but I don't know that we want to signal that this behavior is definitely permanent. I could see the some possibility for adding a hash function in to the time zone objects, at least, at some point in the future, so I'm just going to merge as is. |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working through looking at adopting Python 3, and I've been utilizing the -3 flag to help idenitfy issues with Python 3.
Here's a quick write up I did last week:
https://gist.github.com/rowillia/c0feed97c1863b2d8e5a3ed73712df65
The -3 flagged a few issues in dateutil worth fixing, namely around eq shadowing hash in PY3.
Fixing these issues will help make the -3 flag less noisey for folks running dateutil in production.