#93 support specifiying time zone by full name #153
Conversation
|
Travis build fails for 3.5, though I see no errors running it with tox. Looks like it's not related to my change. |
|
@aschatten Not sure why, I think one of my responses got eaten by e-mail or something. I restarted the build and that fixed the Python 3.5 issue. Did you do some weird rebasing on this branch or something? This PR seems to have a bunch of already-merged commits in it for some reason. |
|
@pganssle thanks for restarting the build. The diff looks right to me, but indeed history seems to be too wide. I can re-create the branch and make a new PR tomorrow. |
|
@aschatten Did you ever create a new version of this with the right history? |
0a3d645 to
8627841
Compare
8627841 to
9128310
Compare
|
@pganssle I was finally able to fix the history. |
|
Thanks, much nicer now. I'll look at this more throughly ASAP and target inclusion in the 2.5.1 release. |
|
@aschatten Sorry to be a pain, but after some extensive changes to the tests, it looks like this is going to need to be rebased to the current master. I can probably apply the changes myself, but I'm not so good with git that I can guarantee that contributions are properly attributed in the git history, so it's probably best if you do it. If you want me to just go ahead and try myself let me know. |
|
@pganssle No problem at all! I will apply the changes myself. I am thinking that I will be able to get it done this weekend. |
|
I pushed this to the next release since it's not particularly urgent. Will merge whenever the rebase is ready. |
|
@aschatten FYI, looks like a new time zone database update is going to be released soon. I'm trying to get out point releases soon after tzdb updates (at least for now), so I think that will be the next opportunity to get this into the stable version of dateutil. |
|
@aschatten FYI, I was able to merge this locally without a problem. I'm working out some kinks before pushing the merged branch to master. |
| tmplst = tmplst.union(info[0]) | ||
| tz_parserinfo.info = (tmplst, max(3, info[1])) | ||
|
|
||
| return tz_parserinfo.info |
There was a problem hiding this comment.
@aschatten Can you explain what this is supposed to be? I get the sense that it's for identifying strings that might be time zones we know about, but what is the 2nd parameter for? The maximum number of segments it could be?
There was a problem hiding this comment.
@pganssle You are right, 1st parameter is a set of possible prefixes and 2nd – maximum number of segments in a full timezone name.
|
Superceded by #227. |
@jarondl this is an updated version of #150. Had to re-create because I somehow messed up my branch and was not merge upstream changes properly.
Fixes #93.