Assign unique host_ids to bound nodes #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Mmm I've started working on the test failures, and I realize my solution is not great because it also creates a |
Contributor
I like this idea. If host_id is getting more precedence in the drivers it makes sense to promote it as a node-level attribute that defaults a random id and can be overridden by user if needed and the |
Contributor
Author
|
OK I'll work on those changes. |
Contributor
Author
|
Done. I force-pushed since there was nothing in common with my initial attempt. |
tolbertam
approved these changes
Mar 6, 2019
Contributor
tolbertam
left a comment
There was a problem hiding this comment.
This looks excellent, thanks! I'll merge and release this today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With JAVA-2165, the Java driver will now index its node metadata by
host_id. This won't work with Simulacron's default behavior, which is to assign the same UUID to every node. We need unique ids.This is the simplest way to address the issue. It fixes my problem but is a bit fragile if the user overrides the key manually, or the whole map by calling
withPeerInfo(Map). Maybe we should check that ahost_idis always present, or even promote it to a top-level property likewithCassandraVersion.