[#66] Add response coalescer #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolbertam
approved these changes
Nov 17, 2018
Contributor
tolbertam
left a comment
There was a problem hiding this comment.
👍 nice and straightforward solution, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this in few different scenarios. I saw not real performance difference when placing the FlushConsolidationHandler() in different places in the pipeline. It's recommended to place it as high in the pipeline as is practical so that's what I did.
This drastically reduces the number of packets that are issued by simulacron, under heavy write load, and the results with C* stress looked as good, or better than my homegrown solution.
Fixes #66