Skip to content

Conversation

@dlg99
Copy link
Collaborator

@dlg99 dlg99 commented Oct 25, 2022

(cherry picked from commit 0854032)

Fixes apache#9962

Motivation

Offloaded ledgers can be orphaned on topic deletion.

This is a redo of apache#15914 which conflicted with concurrently merged apache#17736 thus resulting in apache#17889 .

apache#17736 made a decision to not allow managed ledger trimming for the fenced mledgers because in many case fencing indicates a problems that should stop all operations on mledger. At the same time fencing is used before deletion starts, so trimming added to the deletion process cannot proceed.
After discussion with @eolivelli I introduced new state, FencedForDeletion, which acts as Fenced state except for the trimming/deletion purposes.

Modifications

Topic to be truncated before deletion to delete offloaded ledgers properly and fail if truncation fails.

Verifying this change

local fork tests: dlg99#1

  • Make sure that the change passes the CI checks.

This change added integration tests

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

Nothing changed in the options but admin CLI will implicitly run truncate before topic delete.

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@dlg99 dlg99 marked this pull request as draft October 25, 2022 18:29
@dlg99 dlg99 marked this pull request as ready for review October 26, 2022 16:01
@dlg99 dlg99 merged commit 059f444 into datastax:2.10_ds Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant