Add ability to unwrap BATCH queries #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, when the query used for loading is a BATCH query, DSBulk would forcibly disable its own batching mechanism, to avoid nesting BATCH statements inside protocol-level BATCH messages, which is forbidden. This commit makes it possible for DSBulk to "unwrap" the original batch query, prepare the child statements individually, and then use its batching mechanism to group together all resulting child statements in a (potentially much bigger) BATCH message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400
Prior to this change, when the query used for loading is a BATCH query,
DSBulk would forcibly disable its own batching mechanism, to avoid
nesting BATCH statements inside protocol-level BATCH messages, which is
forbidden.
This commit makes it possible for DSBulk to "unwrap" the original batch
query, prepare the child statements individually, and then use its
batching mechanism to group together all resulting child statements in a
(potentially much bigger) BATCH message.