Count workflow: Print results even if any failures. #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o query billions rows for a few hours and show nothing if some failure happens
adutra
reviewed
Jan 17, 2022
adutra
suggested changes
Jan 18, 2022
workflow/count/src/main/java/com/datastax/oss/dsbulk/workflow/count/CountWorkflow.java
Show resolved
Hide resolved
Contributor
|
Also @smatvienko-tb I would need you to sign our CLA if you haven't done it before: Thanks! |
Contributor
Author
|
Ok. I will commit in a few hours
…On Tue, Jan 18, 2022, 21:21 Alexandre Dutra ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
workflow/count/src/main/java/com/datastax/oss/dsbulk/workflow/count/CountWorkflow.java
<#393 (comment)>:
> @@ -207,10 +207,12 @@ public void close() throws Exception {
if (metricsManager != null) {
metricsManager.reportFinalMetrics();
}
- // only print totals if the operation was successful
- if (success) {
- readResultCounter.reportTotals();
- }
+
+ // Print results even if any failures.
+ // It has no sense to query billions rows for a few hours and show nothing if some failure
+ // happens
+ readResultCounter.reportTotals();
Are you sure you don't want your name engraved for posterity in dsbulk's
commit history? :-) I don't mind if you commit my suggestion as is, as long
as you've signed the CLA.
—
Reply to this email directly, view it on GitHub
<#393 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATBSPA7CY365DQYUWTLDUWDUWW4VLANCNFSM5HK7BZBA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
adutra
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
Please, consider printing COUNT results even if any failures.
It makes no sense to query billions of rows for a few hours and show nothing if some failure happens.
In general, 2-5 failures are fine for a few billion rows. And retry strategy may fix those failures.
The results are always approximate because the cluster keeps writing new data during dsbulk run
In my example, I counted 6.5 Billion rows with 2 failures, spent 2 hours, and got no results at all.
Here is an example of what I got after a few tries: