Forwarder storage #352
Merged
Forwarder storage #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I haven't wired this up yet to the ingestion endpoint by the way, just pulled it all in. |
…into feat/forwarder-storage
nblumhardt
reviewed
May 9, 2024
Member
nblumhardt
left a comment
There was a problem hiding this comment.
Planning to spend some time with this in detail once merged, but LGTM otherwise 👍
test/SeqCli.Tests/Forwarder/Filesystem/InMemoryStoreDirectory.cs
Outdated
Show resolved
Hide resolved
nblumhardt
reviewed
May 9, 2024
src/SeqCli/Forwarder/Filesystem/System/SystemStoreFileAppender.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a durable WAL for the forwarder to ingest events into. It's a pretty sizable piece of software even though it's simple so deserves some documentation once we're ready to stabilize the whole thing.